[Bug 522920] Review Request: tnef - Extract files from email attachments like winmail.dat

Thu Oct 1 10:55:54 UTC 2009

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=522920

--- Comment #8 from Naoki IIMURA <naoki at getpopfile.org>  2009-10-01 06:55:53 EDT ---
Hi,

(In reply to comment #7)
> > # MUST: rpmlint must be run on every package. The output should be posted in
> > the review.
> > => FAIL(1 warning)
> <snip>
> I had tried to fix this, and found that it made no difference. I realize now
> that I was running rpmlint on the -1 version of my package, doh.
> So fixed that.
=> Now OK

> > # MUST: If the package does not successfully compile, build or work on an
> > architecture, then those architectures should be listed in the spec in
> > ExcludeArch. <snip>
> > => FAIL(build error on ppc and ppc64)
> I had not tried build on non intel arches, thanks for triggering a mock build.

You are welcome.

> >   koji build result(ppc):
> >   http://koji.fedoraproject.org/koji/taskinfo?taskID=1716349
> =====
> mv -f .deps/mapi_types.Tpo .deps/mapi_types.Po
> mv -f .deps/tnef_names.Tpo .deps/tnef_names.Po
> mapi_names.c:1307: fatal error: error writing to -: Broken pipe
> compilation terminated.
> The bug is not reproducible, so it is likely a hardware or OS problem.
> gcc: Internal error: Interrupt (program as)
> Please submit a full bug report.
> See <http://bugzilla.redhat.com/bugzilla> for instructions.
> =====
> No idea what is happening here.

I also have no idea. This might be a temporary problem.

> >   koji build result(ppc64) (a test failed):
> >   http://koji.fedoraproject.org/koji/taskinfo?taskID=1716351
> =====
> PASS: directory.test
> PASS: maxsize.test
> \'diff ./body.output ./body.baseline > ./body.diff\' -- Test Failed!
> FAIL: body.test
> PASS: mime-types.test
> cat: write error: Broken pipe
> PASS: stdin.test
> =====
> again broken pipe.

Yes, but seems that 'body.test' fails.
I've checked the file in 'tests/cmdline' directory, but I don't
find any cause of the error.

> I tried to queue some new scratch builds, but I don't remember the proper
> commands to set it up. (certificate error).

I guess this page will help you:
http://fedoraproject.org/wiki/PackageMaintainers/UsingKoji#Fedora_Certificates
You may need to update cert file.

> > # MUST: All build dependencies must be listed in BuildRequires, except for any
> > that are listed in the exceptions section of the Packaging Guidelines ;
> > inclusion of those as BuildRequires is optional. Apply common sense.
> > => FAIL
> <snip>
> And, since the installed .desktop file wouldn't be owned without out this
> package, I am including it now as both Requires and BR.
=> OK

> > # MUST: Packages containing GUI applications must include a %{name}.desktop
> Hmmn, that is an unfortunate side effect. The app is not a gui app, and it
> doesn't make sense for an icon to appear in the normal Application (or other)
> menu, because the app needs an input tnef file to extract to be useful.
> 
> It does make sense to have the right click (open with) menu in nautilus/doplhin
> though. It seems you get one when you want the other, unless there is another
> way to achieve this file mime-type association ?
> 
> I have asked on fedora-packaging list about this item. Perhaps I'm doing
> something that isn't allowed for other reasons ?
=> pending

I don't have enough knowledge about nautilus/dolphin integration.
I'm watching fedora-packaging list.
I hope we can find better solution of this issue.

> > # MUST: Packages must not own files or directories already owned by other
> > packages. <snip>
> > => I can't judge.
> > 
> > Because I don't know who owns '%{_datadir}/mimelnk/application/' directory.
> rpm -qf /usr/share/mimelnk/application/
> kde-filesystem-4-25.fc11.noarch
> , but I think other non kde items (eg gnome desktop uses that folder) live
> there as well.
=> OK

Thanks for the information.

> > # SHOULD: The reviewer should test that the package builds in mock.
> > => FAIL
> > 
> > <snip>
> As you mention above, that is probably because the macro is not defined, so
> adding the build requires fixes that.
=> Now OK

> > # SHOULD: The reviewer should test that the package functions as described. A
> > package should not segfault instead of running, for example.
> > => OK(tested with some files in tests/files/datafiles)
> Did you try the menu integration from either nautilus or dolphin ?
> I would appreciate your feedback on testing from both if you are able ;-)

I had not tested the menu integration.
I've installed the new package and tried to right-click on 'winmail.dat'
but I couldn't see any difference in the menu.
Do I need more action after the installation?
I'm using nautilus.

Naoki

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.