[Bug 507223] Review Request: dalston - Moblin System Information Icons

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507223





--- Comment #36 from Peter Robinson <pbrobinson at gmail.com>  2009-10-03 18:56:10 EDT ---

> Now I'm getting really confused:
> 1. I tried that with 0.1.6-1 and it failed for me.
> 2. This still doesn't fix the "-style pattern rules" errors.

I don't actually see how they are an issue here with regards to a package
review. The job of the package review is to review the packaging not the source
code. I don't see how the style pattern rules are an issue of the package
review, they should be handled upstream. They would only be an issue if it was
to be built with none gnu automake which isn't the case in Fedora.

> 3. Obviously you changed the source from 0.1.6-1 to 0.1.6-2. Please make notice
> of things like this in the review.  

Nope. Same one, otherwise I would have made note of it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.