[Bug 522988] Review Request: afraid-dyndns - A dynamic DNS client for the free service afraid.org

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=522988





--- Comment #39 from Erick Calder <e at arix.com>  2009-10-03 21:36:49 EDT ---
(In reply to comment #38)
> Fine. Remember, the changes must be visible not only for you, but also for the
> other maintainers in Fedora. Sometimes, e. g. when a person is on vacation,
> someone else jumps the gun in case of an urgent problem.

ok. what I've done is added the spec file to ~rpm/cvs/afraid-dyndns and
converted ~/prj/afraid-dyndns/spec to a link that points to it so the spec file
is included in the tarball and lives with the rest of the source.  is that ok?
I don't need the tarball too do I? and the patches?

(In reply to comment #38)
> %if 0%{?fedora} = 10
> %patch0 -p1 -b .orig
> %endif

for some reason -p1 breaks the process with the error:

Patch (afraid-dyndns.F10.patch):
+ /bin/cat /builddir/build/SOURCES/afraid-dyndns.F10.patch
+ /usr/bin/patch -s -p1 -b --suffix .orig --fuzz=0
missing header for unified diff at line 5 of patch
The text leading up to this was:
--------------------------
|Index: Makefile
|===================================================================
|--- Makefile (revision 2470)
|+++ Makefile (revision 2471)
--------------------------
File to patch: 
Skip this patch? [y] 
1 out of 1 hunk ignored

however, -p0 seems to fix that problem.  now, in getting all this to work, I
bumped up the spec file to -5.  It wasn't really my intention but I haven't
figure out my workflow so testing was done at points after a commitment. sigh.

now my question is: if I have a -5 in F-10, do I then have to build -5 for F-11
and up (I'm not sure I understood the point in the link you had sent), or is it
ok to leave those at -2?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.