[Bug 526998] Review Request: volpack - Portable library for fast volume rendering

bugzilla at redhat.com bugzilla at redhat.com
Sun Oct 4 19:21:26 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526998


Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |martin.gieseking at uos.de
               Flag|                            |fedora-review+




--- Comment #11 from Martin Gieseking <martin.gieseking at uos.de>  2009-10-04 15:21:25 EDT ---
With the latest SRPM I was also able to build the package successfully. It was
indeed quite obvious that the problem could be caused by %{?_smp_mflags}. Next
time I'll know better. :)

Anyway, the package looks good now. I couldn't find any further issues to be
fixed. 


$ rpmlint /var/lib/mock/fedora-11-x86_64/result/volpack-*
volpack.x86_64: W: shared-lib-calls-exit /usr/lib64/libvolpack.so.1.0.4
exit at GLIBC_2.2.5
volpack-devel.x86_64: W: no-documentation
5 packages and 0 specfiles checked; 0 errors, 2 warnings.

Both warnings can be ignored.

---------------------------------
keys used in following checklist:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines.

[+] MUST: The spec file name must match the base package %{name}.

[+] MUST: The package must meet the Packaging Guidelines.

[+] MUST: The package must be licensed with a Fedora approved license.
    - BSD license (3 clause variant)

[+] MUST: The License field in the package spec file must match the actual
license.

[+] MUST: File(s) containing the text of the license(s) for the package must be
included in %doc.

[+] MUST: The spec file must be written in American English.

[+] MUST: The spec file for the package MUST be legible.

[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
    $ sha1sum volpack-1.0c7.tgz*
    e8e2f8d4fcc569417aef51d429556068d9205060  volpack-1.0c7.tgz
    e8e2f8d4fcc569417aef51d429556068d9205060  volpack-1.0c7.tgz.1

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
    koji scratch build: 
    http://koji.fedoraproject.org/koji/taskinfo?taskID=1726997

[.] MUST: If the package does not successfully compile, ...

[+] MUST: All build dependencies must be listed in BuildRequires.

[.] MUST: The spec file MUST handle locales properly. 
    - no locales

[+] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.

[.] MUST: If the package is designed to be relocatable, ...
    - not relocatable

[+] MUST: A package must own all directories that it creates. 

[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.

[+] MUST: Permissions on files must be set properly.

[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot}.

[+] MUST: Each package must consistently use macros.

[+] MUST: The package must contain code, or permissable content.

[+] MUST: Large documentation files must go in a -doc subpackage.

[+] MUST: Files in %doc must not affect the runtime of the application.

[+] MUST: Header files must be in a -devel package.

[.] MUST: Static libraries must be in a -static package.
    - no static libs packaged

[.] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
    no .pc files

[+] MUST: If a package contains library files with a suffix, then library files
that end in .so (without suffix) must go in a -devel package.

[+] MUST: devel packages must require the base package using a fully versioned
dependency: Requires: %{name} = %{version}-%{release}

[+] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
    - .la files removed

[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file.
    - no GUI

[+] MUST: Packages must not own files or directories already owned by other
packages.

[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot}.

[+] MUST: All filenames in rpm packages must be valid UTF-8.


[+] SHOULD: The reviewer should test that the package builds in mock.
    - builds in mock

[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
    - builds in koji

[+] SHOULD: The reviewer should test that the package functions as described. 

[+] SHOULD: If scriptlets are used, those scriptlets must be sane.

[+] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
    - doc package 

[.] SHOULD: .pc files should be placed in a -devel pkg.
    - no .pc files

------------------------
The package is APPROVED.
------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list