[Bug 508922] Review Request: system-config-selinux - GUI Code for system-config-selinux, polgen, and lockdown

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508922





--- Comment #16 from David Timms <dtimms at iinet.net.au>  2009-10-05 08:18:06 EDT ---
Had a few cycles to look further at the package...
Additional items to sort out:

15. source0: upstream src location doesn't seem to be correct (or I am doing
something wrong):

$ wget
http://fedorahosted.org/released/s/y/system-config-selinux/system-config-selinux-0.2.tar.gz
--2009-10-05 21:26:11-- 
http://fedorahosted.org/released/s/y/system-config-selinux/system-config-selinux-0.2.tar.gz
Resolving fedorahosted.org... 66.135.52.17
Connecting to fedorahosted.org|66.135.52.17|:80... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location:
https://fedorahosted.org/released/s/y/system-config-selinux/system-config-selinux-0.2.tar.gz
[following]
--2009-10-05 21:26:12-- 
https://fedorahosted.org/released/s/y/system-config-selinux/system-config-selinux-0.2.tar.gz
Connecting to fedorahosted.org|66.135.52.17|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2009-10-05 21:26:13 ERROR 404: Not Found.
=====
or via web browser:
Environment not found
=====
  this means I can't check the md5sum.

16. builds on f11 with the setools-libs-python from rawhide, OK.

17. rpmlint for .src.rpm:
$ rpmlint /home/davidt/rpmbuild/SRPMS/system-config-selinux-0.2-3.fc11.src.rpm
system-config-selinux.src: W: strange-permission selinux-polgengui.desktop 0755
system-config-selinux.src: W: strange-permission system-config-selinux.desktop
0755
system-config-selinux.src: W: strange-permission system-config-selinux.spec
0755
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

-> change those file's perms to 644 before building the srpm, should solve
this.

18. rpmlint for built package:
$ rpmlint
/home/davidt/rpmbuild/RPMS/noarch/system-config-selinux-0.2-3.fc11.noarch.rpm
system-config-selinux.noarch: W: incoherent-version-in-changelog -0.2
['0.2-3.fc11', '0.2-3']
-> as mentioned, need to have the release version matching the current spec
release.

system-config-selinux.noarch: E: file-in-usr-marked-as-conffile
/usr/share/PolicyKit/policy/org.fedoraproject.selinux.policy
-> I don't know whether in this case this actually makes sense, and would be
allowed from the packaging perspective ? 
Is there another package you can point to that does this already ?

system-config-selinux.noarch: W: no-documentation
-> suggest creating at least a basic %doc piece describing basic usage of the
two apps.

system-config-selinux.noarch: W: non-conffile-in-etc
/etc/dbus-1/system.d/org.fedoraproject.selinux.config.conf
-> is that supposed to be adjustable by the user ie does it need %config, so
that a user adjustment won't be overwritten during rpm -U ?

system-config-selinux.noarch: W: empty-%post
-> was there supposed to be something here, like reload of a service or similar
?

1 packages and 0 specfiles checked; 1 errors, 4 warnings.

19. running application:
-> I haven't installed to test. My machine is F11, and doesn't have
selinux-policy >= 3.6.28-4. Would installing that version and running it cause
issues ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.