[Bug 524147] Review Request: libnetdevname -Development environment for libnetdevname

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=524147





--- Comment #17 from Praveen K Paladugu <praveen_paladugu at dell.com>  2009-10-05 11:49:33 EDT ---
Review: 
#user1  rpmlint rpmbuild/SRPMS/libnetdevname-0.0.3-1.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

#user1 rpmlint rpmbuild/RPMS/i386/libnetdevname-0.0.3-1.i386.rpm
libnetdevname.i386: W: incoherent-version-in-changelog 0.0.3 ['0.0.3-1',
'0.0.3-1']
libnetdevname.i386: E: useless-provides libnetdevname
libnetdevname.i386: W: self-obsoletion libnetdevname <= 0.0.3-1 obsoletes
libnetdevname = 0.0.3-1
libnetdevname.i386: W: self-obsoletion libnetdevname <= 0.0.3-1 obsoletes
libnetdevname = 0.0.3-1
libnetdevname.i386: W: shared-lib-calls-exit /usr/lib/libnetdevname.so.0.0.3
exit at GLIBC_2.0
1 packages and 0 specfiles checked; 1 errors, 4 warnings.

#user1 rpmlint rpmbuild/RPMS/i386/libnetdevname-devel-0.0.3-1.i386.rpm
libnetdevname-devel.i386: E: useless-provides libnetdevname-devel
libnetdevname-devel.i386: W: self-obsoletion libnetdevname-devel <= 0.0.3-1
obsoletes libnetdevname-devel = 0.0.3-1
libnetdevname-devel.i386: W: self-obsoletion libnetdevname-devel <= 0.0.3-1
obsoletes libnetdevname-devel = 0.0.3-1
libnetdevname-devel.i386: W: no-documentation
1 packages and 0 specfiles checked; 1 errors, 3 warnings.

#user1 rpmlint rpmbuild/RPMS/i386/libnetdevname-debuginfo-0.0.3-1.i386.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.



Few more:
1) "INSTALL -p" in the spec file is not required, since the Makefile.in already
adds the "-p" flag
2) No need to explicitly mention gcc in BuildRequires.
http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
3) Since gcc package requires libgcc, there is no need to mention libgcc as
well. (can be verified with rpm -qi --requires gcc)


To fix the rpmlint errors:
1) Do not use <= in obsoletes, use < only.
2) No need to explicitly mention %Provides: %{name}= %{version}-%{release}.
This is automatically captured. can be verified with rpm -qpi --provides
rpmbuild/RPMS/i386/libnetdevname-0.0.3-1.i386.rpm
3) the above two comments apply for devel package as well.
4) Make sure to add release number also in the changelog.
5) rpmlint -I shared-lib-calls-exit
shared-lib-calls-exit:
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.


Thank you 
Praveen

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.