[Bug 526444] Review Request: MyGUI - Fast, simple and flexible GUI

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526444





--- Comment #8 from Alexey Torkhov <atorkhov at gmail.com>  2009-10-05 12:22:36 EDT ---
Some comments, most are cosmetic :)

(In reply to comment #2)
> I'm targeting that specific revision (with minor changes ahead of the released
> 2.2.2) because its a dependency of http://dungeonhack.sourceforge.net, an ogre
> game i plan to package in the near future.  
2.2.3 was released some time ago, I think best would be package either latest
release or latest revision from svn.

> Boost license used in MyGUI_Any.h
> License:        LGPLv3+ and Boost
They “wrapped” boost license in this header with LGPL, so no need to specify
boost license separately.

> Summary:        Mygui demo executables and media
May be, call it “MyGUI” in summary?

> # Strip away unittests media and a code sample in media dir
> rm -rf %{buildroot}%{_datadir}/MYGUI/Media/Tools/LayoutEditor/CodeTemplates/
Are you sure that this is not used in generating layout? I can't check it right
now. 

> %package        devel
> Requires:       pkgconfig, ois-devel
May be require ogre-devel too? 

> %doc Readme.txt
This is some compilation instructions - no need to include.

May be split devel documentation in devel-doc subpackage?

And, please, split changelog entries by empty line.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.