[Bug 502614] Review Request: stfl - STFL implements a curses-based widget set for text terminals

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502614





--- Comment #33 from Thomas Janssen <thomasj at fedoraproject.org>  2009-10-06 03:31:26 EDT ---
(In reply to comment #32)
> For -4:
> 
> * About sed/patch
>   - Well, I would say that sed lines used in your spec file
>     are very difficult to read. If no better usage of sed
>     usage is found, please create patches again.

I changed and documented the sed lines. If you think they're still not good
enough, then please educate me.

> * cflags
> (In reply to comment #31)
> > No idea what to do here. If i sed the export CFLAGS from the Makefile and use
> > §RPM_OPT_FLAGS it fails miserably to build. If i add the optflags and dont sed
> > nothing changes.
>   - Actually it is incorrect. You should add %optflags to CFLAGS, not
>     replace CFLAGS completely. For this Makefile, try below:
> ---------------------------------------------------
> export CFLAGS="%{optflags}"
> make prefix=%{_prefix} libdir=%{_lib}
> ---------------------------------------------------

/me bangs head on desk.. I fiddled around with it but haven't seen the
obviously, thanks.

> * %exclude -> rm
> > >   - I prefer to remove unneeded files at %install instead of using
> > >     %exclude unless unavoided.  
> > 
> > I was able to rm -f one of the three. Two %exlude are still in since i honestly
> > dont know exactly where they come from. I'm not a coder. They just come up as:
>   - This is normal when installing perl modules (i.e. these files are created
>     automatically), and you can just remove these files at the end of %install
>     ( like "rm -f %{buildroot}%{_libdir}/libstfl.a" )

Done.

> * Documents
>   - Empty %doc is not needed.  

Removed.

Spec URL: http://thomasj.fedorapeople.org/reviews/stfl.spec
SRPM URL: http://thomasj.fedorapeople.org/reviews/stfl-0.21-5.fc10.src.rpm

http://koji.fedoraproject.org/koji/taskinfo?taskID=1729999

-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.