[Bug 527462] Review Request: python-gmpy - Python interface to GMP

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=527462





--- Comment #3 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-10-06 11:05:05 EDT ---
First notes:

- Don't use
 %define version 1.04
or
 %define name python-%{module}
Just use the Version: and Name: tag. The corresponding macros will be
automatically defined.

- I don't recommend using
 %define module gmpy
either, but that's more of a stylistic point. If you decide to stick with it,
use %global instead of %define
http://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define

- You are missing the Source URL
http://www.fedoraproject.org/wiki/Packaging/SourceURL

- The license tag is incorrect (you need to version it)
http://fedoraproject.org/wiki/Licensing#Good_Licenses

http://fedoraproject.org/wiki/Licensing/FAQ#How_do_I_figure_out_what_version_of_the_GPL.2FLGPL_my_package_is_under.3F

- Drop the explicit Requires: gmp, it is automatically picked up by rpm
http://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires

- Instead of
 %__python
it is possible to use just
 python

- Don't use
 %files -f INSTALLED_FILES
list the files explicitly instead. Here you will need the python-sitearch macro
from
http://fedoraproject.org/wiki/Packaging:Python#System_Architecture

- Consider using a more recommended value of buildroot
 %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

- The changelog entry from Thu May 04 2006 has broken UTF-8, the � should be é.
You can probably just drop the old changelog, since you will end up rewriting a
major part of the spec file anyway.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.