[Bug 523553] Review Request: mutrace - Mutex Tracer
bugzilla at redhat.com
bugzilla at redhat.com
Tue Oct 6 19:49:46 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=523553
--- Comment #13 from Lennart Poettering <lpoetter at redhat.com> 2009-10-06 15:49:44 EDT ---
(In reply to comment #10)
> ? license complies with guidelines
> complies with guidelines, yes. However, I recall a discussion in -devel about
> the licensing of Fedora Infrastructure projects.These are supposed to be
> LGPLv2+ for libraries and GPLv2+ for applications. Yours most likely is not
> bound by these guidelines, and should the infrastructure team decide to use
> mutrace, they can (the combination becomes GPLv3+), so this is up to you.
I don't see how mutrace should ever be used for Fedora infrastructure.
> OK license field accurate
> OK license file not deleted
> OK spec in US English
> OK spec legible
> FIX source matches upstream
> $ sha1sum mutrace-0.1.tar.gz ../SOURCES/mutrace-0.1.tar.gz
> dcb16f9a80262cb608f641ee5c960b15def6ad83 mutrace-0.1.tar.gz
> 6017fc40158663eeffec4c70ba69cf04cde11ef2 ../SOURCES/mutrace-0.1.tar.gz
Fixed now.
> FIX build dependencies complete
> missing binutils-devel
Fixed.
> FIX no dupes in %files
> no dupes, but some unpackaged files: %{_libdir}/libmatrace.so and
> libmutrace-backtrace-symbols.so
Fixed.
> SHOULD
> FIX if license text missing, ask upstream to include it
> corresponding GPL license text not included
It is included.
> FIX package build in mock on all architectures
> not using mock yet, BR problem
Uh?
> OK package functioned as described
> FIX require package not files
> require util-linux-ng rather than /usr/bin/getopt ?
/usr/bin/getopt is pretty generic and changed packages a couple of times in the
past, which is is why I decided to stick with a path dependency instead of
package dependency.
Spec file and srpm nowupdated:
Spec URL: http://0pointer.de/public/mutrace.spec
SRPM URL: http://0pointer.de/public/mutrace-0.1-3.fc12.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list