[Bug 503490] Review Request: ayttm - Universal Instant Messaging Client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503490


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #13 from Parag AN(पराग) <panemade at gmail.com>  2009-10-07 07:27:11 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1732372
+ rpmlint output forSRPM and for RPM.
ayttm.i686: W: file-not-utf8 /usr/share/doc/ayttm-0.6.0/AUTHORS
=> Fix this before cvs import.
+ source files match upstream url
21a59beb5b67f02a8c3bc8679475afd4a8fe62dc  ayttm-0.6.0.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ desktop file installed correctly.
+ Package ayttm-0.6.0-1.fc12.i686 =>
Provides: aim-oscar.so autotrans.so config(ayttm) = 0.6.0-1.fc12 custmsg.so
img2jpc.so import_everybuddy.so import_gaim.so import_gnomeicu.so importicq.so
importlicq.so irc.so jabber.so middle.so msn2.so notes.so rainbow.so
smiley-themer.so smtp.so video_capture.so yahoo2.so
Requires: /bin/bash libX11.so.6 libXpm.so.4 libaspell.so.15 libatk-1.0.so.0
libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3)
libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4)
libc.so.6(GLIBC_2.7) libcairo.so.2 libcrypto.so.10 libdl.so.2
libdl.so.2(GLIBC_2.0) libdl.so.2(GLIBC_2.1) libesd.so.0 libfontconfig.so.1
libfreetype.so.6 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgdk-x11-2.0.so.0
libgdk_pixbuf-2.0.so.0 libgio-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0
libgobject-2.0.so.0 libgthread-2.0.so.0 libgtk-x11-2.0.so.0 libjasper.so.1
libjpeg.so.62 libltdl.so.7 libm.so.6 libm.so.6(GLIBC_2.0) libpango-1.0.so.0
libpangocairo-1.0.so.0 libpangoft2-1.0.so.0 libpthread.so.0
libpthread.so.0(GLIBC_2.0) libpthread.so.0(GLIBC_2.1) librt.so.1 libssl.so.10
libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4)
rtld(GNU_HASH)
+ GUI application

Suggestions:
1) we have moved to hunspell now so please ask upstream to add support for
using hunspell dictionaries.
2) fix rpmlint warning message by using following in %prep
tr -d '\r' < AUTHORS > AUTHORS.new
iconv -f ISO-8859-2 -t UTF-8 AUTHORS.new > AUTHORS

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.