[Bug 523650] Review Request: qmpdclient - A Qt4 based MPD client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523650





--- Comment #18 from Thomas Janssen <thomasj at fedoraproject.org>  2009-10-08 10:16:02 EDT ---
I use %{buildroot} over $RPM_BUILD_ROOT, but that's up to you. As long as you
dont mix it.

* %doc question
You use:
%doc AUTHOR COPYING README Changelog
Thats it.

* desktop-file-install question
http://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage
Don't apply a vendor tag.

Well, there's a man page for desktop-file-install online. But the host is
veeeeeery slow.
http://olympus.het.brown.edu/cgi-bin/man/man2html?desktop-file-install+8


Why you're useing capital letters for your .desktop file?

* patch question
Normal you use: Patch0: foo.patch
and           : %patch0    OR    %patch -P 0

-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.