[Bug 526122] Review Request: vim-latex - Tools to view, edit and compile LaTeX documents in Vim

bugzilla at redhat.com bugzilla at redhat.com
Thu Oct 8 20:23:50 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526122





--- Comment #5 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-10-08 16:23:49 EDT ---
(In reply to comment #4)
>  [!] Buildroot is correct
>      (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))

See
 http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
it is the second one from the top, and is a valid option. (I used vim's rpm
spec file template, which uses that option.)

>  [!] Permissions on files are set properly.

This refers to file permissions: the owner, group and the file mask must be
correct.
http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions

There are no executables, and all files are owned by root:root with 644
permissions. So this is OK.

>  [!] Latest version is packaged.
>  [!] Package does not include license text files separate from upstream.

> my problems: ;)
> * are the permissions correctly set with 'cp -a'? cp -a preserves all
> timestamps and permissions if they are correctly set in the sources. In this
> case, they are. But does this count as 'properly set'?  

Yes, it does.

**

New release at
http://theory.physics.helsinki.fi/~jzlehtol/rpms/vim-latex.spec
http://theory.physics.helsinki.fi/~jzlehtol/rpms/vim-latex-1.5-2.20091002.r1074.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list