[Bug 528096] Review Request: kmagnet - KDE puzzle game with built in editor
bugzilla at redhat.com
bugzilla at redhat.com
Sat Oct 10 06:30:25 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=528096
--- Comment #6 from Kevin Kofler <kevin at tigcc.ticalc.org> 2009-10-10 02:30:24 EDT ---
I haven't run the full checklist yet, so I may find more issues, but at a first
glance:
* Please remove the redundant desktop-file-install call above your
desktop-file-validate call. They both do the same thing (as the file is already
installed) and desktop-file-validate is the simpler solution there.
* You're still trying to use %{_desktopdir} which is not defined anywhere.
* Please use %{_kde4_appsdir} instead of %{_kde4_datadir}/kde4/apps.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list