[Bug 515898] Review Request: imapfilter - A flexible client side mail filtering utility for IMAP servers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515898


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




--- Comment #10 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-10-12 15:30:25 EDT ---
Some notes:

* Using %versin macro
  - Using %{version} macro on Source0 is preferred because with this
    you probably won't have to change Source0 line when version is
    upgraded:
    https://fedoraproject.org/wiki/Packaging/SourceURL#Using_.25.7Bversion.7D

* CFLAGS
  - CFLAGS is still wrong (i.e. Fedora specific compilation flags are
    not correctly honored).
-----------------------------------------------------------------------
    47  + make -j4
    48  cc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32 -march=i686 -mtune=atom
-fasynchronous-unwind-tables -Wall -O
-DMAKEFILE_SHAREDIR='"/usr/share/imapfilter"' -I/usr/local/include   -c -o
auth.o auth.c
    49  cc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32 -march=i686 -mtune=atom
-fasynchronous-unwind-tables -Wall -O
-DMAKEFILE_SHAREDIR='"/usr/share/imapfilter"' -I/usr/local/include   -c -o
buffer.o buffer.c
-----------------------------------------------------------------------
    Fedora's default optimization level is "-O2" (as you can check
    by $ rpm --eval %optflags), which is replaced by the latter
    "-O".

* Installing documents
------------------------------------------------------------------------
mkdir -m 755 -p ${RPM_BUILD_ROOT}%{_defaultdocdir}/%{name}-%{version}/
cp README LICENSE ${RPM_BUILD_ROOT}%{_defaultdocdir}/%{name}-%{version}/
------------------------------------------------------------------------
  - These two lines do nothing and should be removed.
    ! build.log shows this:
------------------------------------------------------------------------
   120  + mkdir -m 755 -p
/builddir/build/BUILDROOT/imapfilter-2.0.11-2.fc12.i386/usr/share/doc/imapfilter-2.0.11/
   121  + cp README LICENSE
/builddir/build/BUILDROOT/imapfilter-2.0.11-2.fc12.i386/usr/share/doc/imapfilter-2.0.11/
.....
.....
   133  Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.JZOnjc
   134  + umask 022
   135  + cd /builddir/build/BUILD
   136  + cd imapfilter-2.0.11
   137  +
DOCDIR=/builddir/build/BUILDROOT/imapfilter-2.0.11-2.fc12.i386/usr/share/doc/imapfilter-2.0.11
   138  + export DOCDIR
   139  + rm -rf
/builddir/build/BUILDROOT/imapfilter-2.0.11-2.fc12.i386/usr/share/doc/imapfilter-2.0.11
   140  + /bin/mkdir -p
/builddir/build/BUILDROOT/imapfilter-2.0.11-2.fc12.i386/usr/share/doc/imapfilter-2.0.11
   141  + cp -pr README LICENSE
/builddir/build/BUILDROOT/imapfilter-2.0.11-2.fc12.i386/usr/share/doc/imapfilter-2.0.11
   142  + exit 0
------------------------------------------------------------------------
      Especially see the lines 139-140.
      i.e. %doc foo (where foo is not a absolute path) means:
      - First clean up %buildroot%_defaultdocdir/<rpm_name>-%version completely
      - Then create %buildroot%_defaultdocdir/<rpm_name>-%version and copy the
        specified files into the directory.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.