[Bug 226066] Merge Review: libXcursor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226066





--- Comment #4 from Parag AN(पराग) <panemade at gmail.com>  2009-10-12 23:13:48 EDT ---
(In reply to comment #2)
> Sorry, but you missed a couple of issues:
>
> - md5sum is 7dcdad1c10daea872cb3355af414b2ca, both for upstream as well as for
> the file from lookaside cache
  Thanks. I started using sha1sum

> - timestamps not preserved during iconv
  I wonder how can we preserve timestamps when using iconv. Can you please
provide me an example?

> - timestamp of index.theme not preserved during install
   Thanks will update in SPEC.

> - permissions are not 
> - /usr/share/ hardcoded, although commented out
  will better remove comment then.

> - devel package missing "Requires: xorg-x11-proto-devel"
   Ok

> - why do we still inherit Bluecurce in index.theme?
   Need to check with maintainers.....

> - make is not verbose, so RPM_OPT_FLAGS cannot be verified
>   CC     cursor.lo
>   CC     display.lo
>   CC     file.lo
>   CC     library.lo
>   CC     xlib.lo
>   CCLD   libXcursor.la

  will take care of this.
> 
> I know you are doing a lot of reviews, but IMO the quality must not suffer from
> the quantity.  
Thanks. I know that but reason of doing these merge reviews in hurry is I was
long time waiting for some time to give to review these but finally I decided
to complete this as maintainers himself not interested for such minor thing
changes in spec.

Feel free to cross verify my reviews :)

I really don't want to start again debate on why merge-reviews maintainers are
not taking responsibility to change spec according to packaging guidelines.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.