[Bug 226066] Merge Review: libXcursor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226066





--- Comment #5 from Christoph Wickert <cwickert at fedoraproject.org>  2009-10-13 04:41:32 EDT ---
(In reply to comment #4)
> (In reply to comment #2)
> > - md5sum is 7dcdad1c10daea872cb3355af414b2ca, both for upstream as well as for
> > the file from lookaside cache
>   Thanks. I started using sha1sum

Yeah, after the third mismatch I got it. The review Guidelines still state "The
sources used to build the package must match the upstream source, as provided
in the spec URL. Reviewers should use md5sum for this task." If you use
something different, please make notice in the bug.

> > - timestamps not preserved during iconv
>   I wonder how can we preserve timestamps when using iconv. Can you please
> provide me an example?

Second example on 
https://fedoraproject.org/wiki/PackageMaintainers/PackagingTricks#Convert_encoding_to_UTF-8

> Thanks. I know that but reason of doing these merge reviews in hurry is I was
> long time waiting for some time to give to review these but finally I decided
> to complete this as maintainers himself not interested for such minor thing
> changes in spec.

Sad but true, I know this very well from other merge reviews. Keep on your good
work!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.