[Bug 517488] Review Request: vhostmd - Virtualization host metrics daemon

bugzilla at redhat.com bugzilla at redhat.com
Tue Oct 13 09:51:09 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517488





--- Comment #7 from Matthew Booth <mbooth at redhat.com>  2009-10-13 05:51:07 EDT ---
(In reply to comment #6)
> > [2] Tarball: I appreciate the upstream hosting issue. It still looks odd,
> > though. The srpm contains vhostmd-vhostmd-0.3.tar.gz (note the repeated
> > vhostmd-). make dist on the source creates the expected vhostmd-0.3.tar.gz. Is
> > this intentional?
> 
> Yeah, this is all fscked up.  The upstream issue is being
> discussed here:
> 
> http://lists.opensuse.org/vhostmd/2009-10/msg00007.html

Ok, it doesn't sound like the gitorious solution will fly. Can you do a 'make
dist' on the source yourself and add a comment to the spec identifying the
commit the dist is based on (presumably
a92f35045ab8c7b88c714a44623219ffac3caea1 in this case). This should at least be
verifiable and reproducible. Of course, this would be easier if upstream would
add a tag to this commit, then you could just document the name of the tag.

> > [3] Unfortunately this now fails to build on ppc:
> > 
> > http://koji.fedoraproject.org/koji/taskinfo?taskID=1742110
> > 
> > You may need some additional configure magic when xen-devel isn't available.  
> 
> OK I get this now.  It's actually a feature of vhostmd that
> I wasn't aware of up to now.  As well as using the metrics
> disk to export data, it can also export it through xenstore.
> 
> Unfortunately the current code doesn't allow that to be
> configured out at compile time (and thus always requires
> the Xenstore client library to be available).
> 
> I think the best thing here is to add back the
> ExclusiveArch temporarily until I can get it fixed
> upstream.  

Agreed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list