[Bug 527049] Review Request: python-ssl - SSL wrapper for socket objects (2.3, 2.4, 2.5 compatible)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=527049


Matt Domsch <matt_domsch at dell.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |matt_domsch at dell.com




--- Comment #1 from Matt Domsch <matt_domsch at dell.com>  2009-10-13 10:44:46 EDT ---
I'll take the review.

Missing a license file in %doc.  Not strictly required as the upstream tarball
doesn't have it, but would be nice to add.

Group: tag can arguably be "Development/Libraries" and not
"Development/Languages".

Use of 'cp' in %install should use 'cp -p' to preserve file timestamps.


rpmlint is clean.
$ rpmlint SPECS/python-ssl.spec RPMS/x86_64/python-ssl-1.15-1.fc10.x86_64.rpm
SRPMS/python-ssl-1.15-1.fc10.src.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Name: OK
spec name: OK
packaging guidelines: ok
license: ok
license field: ok
license text file: not present in upstream. ok.
english spec: ok
legible spec: ok
sources match upstream: ok
$ sha1sum ssl-1.15.tar.gz SOURCES/ssl-1.15.tar.gz 
18035755a0ab75fe23191b5588d4572bfe675b5c  ssl-1.15.tar.gz
18035755a0ab75fe23191b5588d4572bfe675b5c  SOURCES/ssl-1.15.tar.gz

builds on x86_64: ok
doesn't build on some arch: unknown, nothing indicated.  ok.
buildrequires: ok
locales: not used, ok.
shared libs: none. ok
no system libs: ok
relocatable: no.  ok.
own dirs: ok
no duplicate files: ok
file perms: ok
clean section: ok
consistent use of macros: ok
code not content: code.  ok
large docs: none.  ok.
runtime docs: no. ok.
header files: none. ok
static libs: none. ok
pkgconfig: none. ok
devel versioned dep: none. ok.
no .la: none. ok
desktop file: none. ok
dir ownership: ok
install rm-rf: ok
utf8: ok

SHOULDs:
license: noted above
translated description: not available
builds in mock: yes, koji builds linked above
builds for target arches: yes via koji above
tested: not done during review
scriptlets sane: none, ok.
subpackages: none, ok
pkgconfig: none, ok
file deps: none, ok


With minor modifications above, this is a clean package, thanks.  Please make
suggested changes and I'll approve.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.