[Bug 528847] Review Request: Netpipe - A protocol independent network performance tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=528847


Matt Domsch <matt_domsch at dell.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |matt_domsch at dell.com
         AssignedTo|nobody at fedoraproject.org    |matt_domsch at dell.com
               Flag|                            |fedora-review?




--- Comment #1 from Matt Domsch <matt_domsch at dell.com>  2009-10-14 00:27:13 EDT ---
I can sponsor you.

Just a few recommendations.

The comments at the top of the file don't make sense in Fedora; just remove
them.

add %{?dist} tag on the Release field.

%setup lacks -q flag

make lacks CFLAGS="$RPM_OPT_FLAGS" to pick up standard options.  Drop current
setting of CFLAGS.

fix permission of SPECS/netpipe.spec to be 0644.

BuildRoot line could be one of the better ones.  For F11 and higher it'll get
ignored anyhow, but I like to use the best one available when we can.
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

Drop Obsoletes line.  This is the first implementation for Fedora.



remove executable permission on docs files.  Or, actually install them into
/usr/bin/ and include them in %files.  If the latter, rpmbuild will
automatically find the dependency on /bin/csh for you. ;-)

be sure the manpage isn't marked %doc.

once you've done the above, you can use %defattr(-, root, root, -) in %files.

With these changes, rpmlint is silent.
Then I'll do the formal review.

Thanks,
Matt

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.