[Bug 528841] Review Request: sks - Synchronizing Key Server
bugzilla at redhat.com
bugzilla at redhat.com
Wed Oct 14 17:37:41 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=528841
Toshio Ernie Kuratomi <a.badger at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |a.badger at gmail.com
AssignedTo|nobody at fedoraproject.org |a.badger at gmail.com
Flag| |fedora-review+
--- Comment #3 from Toshio Ernie Kuratomi <a.badger at gmail.com> 2009-10-14 13:37:40 EDT ---
Using the new srpm here:
http://fedorapeople.org/~nb/review/sks-1.1.1-2.fc11.src.rpm
Good:
* Package named appropriately. Upstream tarball and binary are sks.
* Licensed GPLv2+, sources confirm
* license file included in package
* Spec file is legible
* Source matches upstream
* No locale files
* Not a library package
* No bundled libraries
* Not relocatable
* All created directories are owned and no others.
* Proper %clean
* macros used consistently
* Code, not content
* No %doc files affect the package runtime
* Not a GUI application
* All filenames are utf-8
* Package builds forall arches in koji
* rpmlint clean
* C libraries are dynamically linked
* Files have good permissions
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list