[Bug 516514] Review Request: globus-authz - Globus Toolkit - Globus authz library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516514


Steve Traylen <steve.traylen at cern.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |steve.traylen at cern.ch
         AssignedTo|nobody at fedoraproject.org    |steve.traylen at cern.ch
               Flag|                            |fedora-review+

Bug 516514 depends on bug 516513, which changed state.

Bug 516513 Summary: Review Request: globus-authz-callout-error - Globus Toolkit - Globus authz error library
https://bugzilla.redhat.com/show_bug.cgi?id=516513

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         Resolution|                            |ERRATA
             Status|ASSIGNED                    |CLOSED



--- Comment #1 from Steve Traylen <steve.traylen at cern.ch>  2009-10-14 16:52:30 EDT ---
Review of globus-authz:

koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1746668

MUST:

yes: 
$ rpmlint globus-authz.spec ../SRPMS/globus-authz-0.7-1.fc11.src.rpm
../RPMS/x86_64/globus-authz-*
../RPMS/noarch/globus-authz-doc-0.7-1.fc11.noarch.rpm 
globus-authz-devel.x86_64: W: no-documentation
5 packages and 1 specfiles checked; 0 errors, 1 warnings.

which is fine since it is in the doc package.

yes: Package name - globus guidelines
yes: Spec File name - globus guidelines
yes: Packaging guidelines
yes: Apache 2.0
yes: .spec ASL 2.0
yes: GLOBUS_LICENSE included.
yes: american english.
yes: Upstream source matches.
$ diff -r --brief gt4.2.1-all-source-installer/source-trees/gsi/authz/source
~/rpmbuild/SOURCES/globus_authz-0.7
Only in /home/steve/rpmbuild/SOURCES/globus_authz-0.7: GLOBUS_LICENSE

which is expected.

yes: builds as per koji build above.
yes: locales not present.
yes: Calls ldconfig appropriate
yes: No system libs included.
yes: not relocatable.
yes: All files and directories created in the package are owned.
yes: files not listed twice.
yes: defattr used everywhere.
yes: Buildroot is removed in %clean.
yes: consistant macros
yes: no large docs.
yes: docs not needed runtime.
yes: headers in -devel file.
yes: libs correctly in -devel package.
yes: main package is needed by devel package.
yes: no .la files present.
yes: no gui.
yes: does not own files belonging to other packages.
yes: buildroot removed in %install.
yes: utf8

APPROVED

Steve

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.