[Bug 527488] Review Request: drbd - drbd tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=527488





--- Comment #27 from LINBIT <partner at linbit.com>  2009-10-15 02:01:18 EDT ---
(In reply to comment #24)
> Some more things...
> 
> building the km (for testing) fails in differnt ways.
> 
> Try builds with:
> 
> rpmbuild -ba --with km SPECS/drbd.spec
> 
> rpmbuild -ba --define 'kernelversion 2.6.31.1-56.fc12.x86_64' --define 'kdir
> /lib/modules/2.6.31.1-56.fc12.x86_64/build' --with km SPECS/drbd.spec
> 
> Then I had to add:
> 
> %configure \
>     %{?_without_utils} \
>     %{?_with_km} \
>     KDIR=%{kdir} \
>     %{?_without_udev} \
> 
> ^^ KDIR in there otherwise the configure assumes uname -r that might not be
> true if I did override from command line.

Yes, but you'll notice that when setting KDIR from configure you only set the
KDIR _default_ in the generated Makefiles, which are meant to be overridden
from make if necessary (they're defined with "?="). The whole idea was to be
able to build kernel modules for different flavors without rerunning configure
(and thereby with better short-circuiting).

So the fact that in the spec KDIR is only passed in on make, not on configure,
is intentional and it does work for me. If it doesn't for you, please send me
your build logs by private email and I'll be happy to look into them.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.