[Bug 527488] Review Request: drbd - drbd tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=527488





--- Comment #40 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-10-15 15:11:19 EDT ---
As one of the sponsor members I want to ask some questions before
someone (including) me can start review:

- Would you explain why non-arch-independent files under /usr/lib/%{name}
  cannot be moved to %{_datadir}?

- Would you explain why you want to keep "%bcond_with km" part 
  on the spec file which seems completely unneeded on Fedora 
  ( according to your comments )?
  Removing parts which are not needed for Fedora will make the spec
  file more readable and preferred.
  ( And I think anyway this "%bcond_with km" part is completely
    broken because we don't ensure that the kernel version of
    the build server and of the host that the rebuilt binary rpm
    is to be used is the same. For example while F-12 kernel is
    now 2.6.31.1, the build server to build F-12 rpms uses
    2.6.18 kernel: see the build.log of your comment 33)

- Similarly, would you explain why you want to keep
  %if %{without udev} part on Fedora?

- Please remove duplicate file entries. Try:
  $ rpm -qlp *rpm | sort | uniq -d
  This will show that some files are included in multiple rpms.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.