[Bug 528847] Review Request: Netpipe - A protocol independent network performance tool

bugzilla at redhat.com bugzilla at redhat.com
Fri Oct 16 01:15:55 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=528847





--- Comment #5 from Matt Domsch <matt_domsch at dell.com>  2009-10-15 21:15:53 EDT ---
A few more items:

By changing the name, you can drop the define real_name and its use in %setup.

https://fedoraproject.org/wiki/Licensing
says that the License tag should be:
License: GPL+
because no version is specified in the source.

I think omitting the [fg]eplot and nplaunch files is wrong.  You can chmod them
0644 and then include them in %doc.

And bump the Release number, from 1.2 to 2, in case anyone happens to have the
older release somehow.

Thanks,
Matt

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list