[Bug 527488] Review Request: drbd - drbd tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=527488





--- Comment #43 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-10-15 22:43:00 EDT ---
(In reply to comment #42)
> > >   Removing parts which are not needed for Fedora will make the spec
> > >   file more readable and preferred.
> > >   ( And I think anyway this "%bcond_with km" part is completely
> > >     broken because we don't ensure that the kernel version of
> > >     the build server and of the host that the rebuilt binary rpm
> > >     is to be used is the same.
> > 
> > That's actually irrelevant; we can build the userland on any kernel, it doesn't
> > need to match that of the kernel module build.
> 
> - What I am speaking is when "--with km" is passed to your srpm
>   and not speaking about only building userland part binary rpm.
>   So if you're thinking of userland build, again "%bcond_with km"
>   is not needed.

To be clear, I am asking to remove all kernel module related part from your
spec file (i.e. removing all parts which are in effect only
when "--with km" is passed to your srpm)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.