[Bug 528847] Review Request: Netpipe - A protocol independent network performance tool

bugzilla at redhat.com bugzilla at redhat.com
Fri Oct 16 11:58:46 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=528847





--- Comment #9 from Scott Collier <boodle11 at gmail.com>  2009-10-16 07:58:44 EDT ---
(In reply to comment #8)
> [fg]eplot in particular should be in %doc I think, and unmarked as executable. 
> They're very poor shell scripts, similar to each other and only really
> differing in where they're placing their output file, which doesn't take the
> output file name as an argument (it has a file name hardcoded, one in the
> current directory and one in ~/ but still poor form).  That's crap I wouldn't
> want in /usr/bin.
> 
> nplaunch is a useless wrapper around invoking ssh, and including it in
> /usr/bin/ sucks in tcsh as a dependency.  Ugh.
> 
> I think they're OK for %doc chmod 0644, but not in %bin.  

Ok. Done.

Spec URL: http://boodle.fedorapeople.org/RPMS/NetPIPE.spec
SRPM URL: http://boodle.fedorapeople.org/RPMS/NetPIPE-3.7.1-2.fc11.src.rpm 

No errors with rpmlint.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list