[Bug 527308] Review Request: xmltooling - XML signing and encrytion library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=527308


Mattias Ellert <mattias.ellert at fysast.uu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |mattias.ellert at fysast.uu.se
               Flag|                            |fedora-review?




--- Comment #2 from Mattias Ellert <mattias.ellert at fysast.uu.se>  2009-10-16 08:34:16 EDT ---
Fedora review xmltooling-1.2.2-1.fc11.src.rpm 2009-10-16

$ rpmlint 3207912553565521572496900/result/xmltooling/*.rpm
xmltooling-devel.x86_64: W: no-documentation
5 packages and 0 specfiles checked; 0 errors, 1 warnings.

+ rpmlint OK
+ Package name follows guidelines
+ Specfile named according to the package
+ Package's license tag (ASL 2.0) is a Fedora approved license
+ Package's license matches the license of the sources
+ The license file (LICENSE.txt) is included as %doc
+ Specfile is written in legible English
+ Source matches upstream:

2331cbcf257319c40854cefd1783fa96  xmltooling-1.2.2.tar.gz
2331cbcf257319c40854cefd1783fa96  src/xmltooling-1.2.2.tar.gz

Comment: The URL used for the Source is not permanent since it contains as one
of the elements in its path the element "latest". When the next release is
issued by upstream this URL will no longer exist. It might be better to use
a specific version instead of "latest" in the Source URL.

+ Package compiles in mock (Fedora 11)
+ Build requirements are sane
+ Main package calls ldconfig in scriptlets
+ No bundled libraries

- Main package installs files in /usr/share/xml without owning it or without
  requiring a package that owns it. Suggestion: add Requires: xml-common

- The doc package own /usr/share/doc/xmltooling-1.2.2 which is already owned
  by the main package

+ Permissions are sane and %files have %defattr
+ Clean clears buildroot
+ Spec uses macros consistently
+ Contains code
+ Documentation is in doc package
+ %doc is not runtime essential
+ Headers are in devel
+ No static libraries
+ devel requires main with fully qualified version
+ Package does not own others directories
+ Install clears buildroot
+ Filenames valid UTF-8

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.