[Bug 529387] Review Request: rcrpanel - Create a front panel for an electronics device

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=529387





--- Comment #2 from Jason Tibbitts <tibbs at math.uh.edu>  2009-10-16 12:06:23 EDT ---
A few comments:

rpmlint says:

  rcrpanel.x86_64: W: spurious-executable-perm 
   /usr/share/doc/rcrpanel-3.4/rcrpanel.txt
  rcrpanel.x86_64: E: wrong-script-end-of-line-encoding 
   /usr/share/doc/rcrpanel-3.4/rcrpanel.txt
I don't see any reason why that file would be executable.  Once you fix that,
the second complaint will change but the underlying issue is the same: the file
has DOS-style line ending.  A suggestion for fixing that is at
http://fedoraproject.org/wiki/Common_Rpmlint_issues#wrong-file-end-of-line-encoding

The package does not build using the proper set of compiler flags; currently it
just uses "-g -Wall", while it needs to use whatever is in $RPM_OPT_FLAGS. 
Adding
  CFLAGS="$RPM_OPT_FLAGS"
to the make call gets that working, but then the source no longer compiles due
to several errors of the form:
  /builddir/build/BUILD/rcrpanel-3.4/rcrpanel.c:620: undefined reference to 
   `sincos'

There is no reason to gzip the manpage; rpmbuild will automatically use its
preferred compression method (which we may indeed change in the future).

Note that modern Fedora needs neither the BuildRoot: tag nor the "rm -rf" line
at the start of %install.  If you intend this to go into EPEL, though, then
you'll probably want to keep those so you don't have to maintain a different
spec for EPEL.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.