[Bug 528096] Review Request: kmagnet - KDE puzzle game with built in editor

Sun Oct 18 04:39:47 UTC 2009

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=528096

--- Comment #11 from Kevin Kofler <kevin at tigcc.ticalc.org>  2009-10-18 00:39:45 EDT ---
MUST Items:
! rpmlint output:
  macros in changelog need fixing
+ named and versioned according to the Package Naming Guidelines
+ spec file name matches base package name
+ Packaging Guidelines:
  + License: GPLv3+ valid, matches actual license
  + No known patent problems
  + No emulator, no firmware, no binary-only or prebuilt components
  + Complies with the FHS
  + proper changelog, tags, BuildRoot, BuildRequires, Summary, Description
  + no non-UTF-8 characters
  + all relevant documentation included as %doc
  + RPM_OPT_FLAGS are used (%cmake_kde4 macro)
  + debuginfo package is valid
  + no static libraries nor .la files
  + no duplicated system libraries
  + no rpaths
  + no configuration files, so %config guideline doesn't apply
  + no init scripts, so init script guideline doesn't apply
  + .desktop file for the GUI app kmagnet present
  + desktop-file-validate is used in %install and the .desktop file passes
validation
  + no timestamp-clobbering file commands
  + _smp_mflags used
  ! scriptlets are sane, but contain unnecessary lines (see SHOULD items)
  + not a web application, so web application guideline doesn't apply
  + no conflicts
+ complies with all the legal guidelines
+ COPYING packaged as %doc (but it's the wrong one, see SHOULD items)
+ source matches upstream:
  MD5: 1e996f149ea0a9fe11c73191a582088b
  SHA1: f6a24f5065802a5aebaf6f1fc6d8054ceef2705f
  SHA256: 0681cf46e31b96faaaeec80779faf0f7570609708eabbca2f12f0a5d6f41ae72
+ builds on at least one arch (F13 Koji scratch build)
+ no known non-working arches, so no ExcludeArch needed
+ no missing BuildRequires (builds in mock)
+ no translations, so translation/locale guidelines don't apply
+ no shared libraries, so no ldconfig calls neeed
+ no duplicated system libraries
+ package not relocatable
! ownership not correct:
  + doesn't own directories owned by another package, but...
  ! doesn't own 2 package-specific directories it should own:
    %{_kde4_docdir}/HTML/en/%{name}/
    %{_kde4_appsdir}/kMagnet/
    please remove the * at the end of those lines, you want to own the whole
directories, not just their contents!
+ no duplicate files in %files
+ permissions correct, defattr used correctly
+ %clean section present and correct
+ macros used where possible
+ no non-code content
+ no large documentation files, so no -doc package needed
+ no %doc files required at runtime
+ no header files which would need to be in a -devel subpackage
+ no static libraries, so no -static package needed
+ no .pc files, so no Requires: pkgconfig needed
+ no devel symlinks which would need to be in a -devel subpackage
+ no -devel package, so "In the vast majority of cases, devel packages must
require the base package using a fully versioned dependency: Requires: %{name}
= %{version}-%{release}" is irrelevant
+ no .la files
+ .desktop file for the GUI app kmagnet present
+ desktop-file-validate is used in %install and the .desktop file passes
validation
+ buildroot is deleted at the beginning of %install
+ all filenames are valid UTF-8

SHOULD Items:
! license file: upstream is including a copy of the GPLv2 when the license
headers actually reference the GPLv3+! So the COPYING upstream is shipping does
not actually apply. Please ask upstream to fix this, as per SHOULD item: "If
the source package does not include license text(s) as a separate file from
upstream, the packager SHOULD query upstream to include it." But, as per "MUST:
If (and only if) the source package includes the text of the license(s) in its
own file, then that file, containing the text of the license(s) for the package
must be included in %doc.", it is OK to ship a package without a copy of the
license if upstream doesn't include it, so this is not a review blocker.
+ no translations for description and summary provided by upstream
+ package builds in mock (F13 Koji scratch build)
+ submitter reports having successfully tested the package functionality
! scriptlets contain unnecessary:
  update-desktop-database -q &> /dev/null
  update-mime-database %{_kde4_datadir}/mime &> /dev/null
  lines. There is no MIME type being registered (so update-mime-database is
unnecessary) nor being referenced in the .desktop file either (so
update-desktop-database is not needed either). And where did you get the -q
from? It's not in: https://fedoraproject.org/wiki/Packaging:ScriptletSnippets
  (The scriptlets are otherwise valid.)
+ no subpackages other than -devel (in fact no subpackages at all), so
"Usually, subpackages other than devel should require the base package using a
fully versioned dependency." is irrelevant
+ no .pc files, so "placement of .pc files" is irrelevant
+ no file dependencies

Please fix the following items:
* escape (double) the % signs in %changelog (MUST)
* own the following 2 directories:
    %{_kde4_docdir}/HTML/en/%{name}/
    %{_kde4_appsdir}/kMagnet/
  not just the files they contain (i.e. remove the * at the end of those lines)
(MUST)
* remove the unnecessary lines from the %postun and %posttrans scriptlets:
  update-desktop-database -q &> /dev/null
  update-mime-database %{_kde4_datadir}/mime &> /dev/null
  (SHOULD, and trivial to fix, so please fix this while you are at fixing
things unless you have a good reason not to)
* ask upstream to include a copy of the GPLv3 to match their license headers
(SHOULD, but you don't have to wait for an answer to get the package approved)

Once you addressed these issues, I'll have another quick look to make sure it's
all right and then I'll approve your package and sponsor you.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.