[Bug 526916] Review Request: orc - The Oil Runtime Compiler

bugzilla at redhat.com bugzilla at redhat.com
Sun Oct 18 18:01:53 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526916





--- Comment #5 from Fabian Deutsch <fabian.deutsch at gmx.de>  2009-10-18 14:01:52 EDT ---
(In reply to comment #4)
> - you can drop pkgconfig and autoconf from BuildRequires
> - remove %makeinstall 
> - replace pkg-config by pkgconfig
> - replace "rm -Rf" by "rm -rf"
> - I suggest to replace %{_includedir}/* by %{_includedir}/%{name}-0.4/ to make
> clear that the header files go to a subfolder
> - add the doc files COPYING README to the base package and drop them from tools
> (even if rpmlint will print a warning about missing docs)

all done.

> - I suggest to add the compiler orcc to the devel package in order to remove
> the tools subpackage, since orcc is also a development tool, and it's a bit of
> overhead to create a separate package for just one small additional file. 

done. I can not remeber why I put just the compiler into a different package.

> - the documentation is quite extensive so it's probably a good idea to put it
> into a doc subpackage

done. Good idea.

> - Could you explain the need for the .conf file? As far as I can see, it's not
> necessary  

There are files located in ${_libdir}/orc/, so don't we need this conf file, to
tell ldconfig to look in this folder too?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list