[Bug 529466] Review Request: linbox - C++ Library for High-Performance Linear Algebra

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=529466





--- Comment #11 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-10-18 16:30:16 EDT ---
rpmlint output:
linbox.x86_64: W: shared-lib-calls-exit /usr/lib64/liblinboxsage.so.0.0.0
exit at GLIBC_2.2.5
linbox.x86_64: W: shared-lib-calls-exit /usr/lib64/liblbdriver.so.0.0.0
exit at GLIBC_2.2.5
5 packages and 0 specfiles checked; 0 errors, 2 warnings.

(Same warnings on i386, so everything is OK.)


MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK

MUST: The spec file for the package is legible and macros are used
consistently. NEEDSWORK
- You are still missing comments from the patches. Please add comments in the
spec file to indicate what the patch does.

MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK

MUST: The License field in the package spec file must match the actual license.
OK
- There are some files also in linbox/ that are missing proper license headers.
Ask upstream to add them.

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A
MUST: Optflags are used and time stamps preserved. OK
MUST: Packages containing shared library files must call ldconfig. OK
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK


MUST: Large documentation files must go in a -doc subpackage. OK
- Note that
 %doc htmldocs
includes the htmldocs directory, so you currently have
 /usr/share/doc/linbox-doc-1.1.6/htmldocs/
in -doc. Instead you should use
 %doc htmldocs/*

- Instead of
 # These docs are installed to the wrong place (/usr/doc), so we move
 # them to -doc.
 mv %{buildroot}%{_prefix}/doc ./htmldocs
and in %files of -doc
 %doc htmldocs
I suggest
 # Remove docs that are installed in the wrong place
 rm -rf %{buildroot}%{_prefix}/doc
and in %files of -doc
 %doc doc/linbox.html doc/linbox-html
as this is surer to preserve time stamps.

- Also, note that
 BuildArch:      noarch
only works on Fedora >= 11. If you want to build for EPEL, use
 %if 0%{?fedora} > 10 || 0%{?rhel} > 5
  BuildArch: noarch
 %endif


MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. NEEDSWORK
- Add NEWS, README and TODO.

MUST: Header files must be in a -devel package. OK
MUST: Static libraries must be in a -static package. N/A
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. OK
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. OK
MUST: Packages does not contain any .la libtool archives. OK
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.