[Bug 529387] Review Request: rcrpanel - Create a front panel for an electronics device

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=529387


David Nalley <david at gnsa.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at gnsa.us




--- Comment #13 from David Nalley <david at gnsa.us>  2009-10-18 20:50:10 EDT ---
Hi John:

Your Source0 line needs to be the url to the software:
For instance: 
http://qslmaker.mi-nts.org/downloads/Panel-3.2.tar.gz

See: http://fedoraproject.org/wiki/Packaging/SourceURL   for more details. 

License is incorrect in the spec file (it's listed as GPLv2) - rcrpanel.c has
GPLv2+ in it. 

While not necessary you can reduce some of the chatter in %files by reducing: 
%doc rcrpanel.txt
%doc README
%doc COPYING
%doc AUTHORS


to: 
%doc rcrpanel.txt README COPYING AUTHORS

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.