[Bug 527488] Review Request: drbd - drbd tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=527488





--- Comment #58 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-10-21 12:24:26 EDT ---
(In reply to comment #55)

> > * %prep <-> %build
> >   - Forgot to mention that we usually write %configure in
> >     %build, not in %prep.
> 
> I got the idea from the cluster-glue package that has just very recently passed
> package review and has been accepted into Fedora, which uses the exact approach
> of invoking %configure from %prep. Putting %configure into %prep seems more
> logical to me than %build.

- Usually we think that
  - %prep should just unpack the tarball and apply some patches
    needed for build process (and maybe sed, iconv, and so on)

  - %build should do things related to building the source
    (usually configure -> make)
    Note that when you want to modify configure option for
    some reason, you have to unpack the source again if you
    write configure in prep. On the other hand when configure is
    executed in %build, you can omit unpacking source by
    $ rpmbuild -bc --short-circuit (by the way if patches are
    modified, usually we have to begin with unpacking source again...)

  - And %install should just install files (if possible, usually
    some modification is needed after installing files)
    Here when we just want to fix %files list or so, we can begin
    with $ rpmbuild -bi --short-circuit .

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.