[Bug 527245] Review Request: evolution-couchdb - An evolution backend to CouchDBs for PIM information

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=527245


Sebastian Dziallas <sebastian at when.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?




--- Comment #5 from Sebastian Dziallas <sebastian at when.com>  2009-10-21 12:29:29 EDT ---
So let's get this done now! Here's are the two things I came across:

* license field is apparently wrong. COPYING and the headers indicate that it's
GPL v3 or later and not GPLv2. Please fix this.

* rpmlint is not yet calm - you might want to fix that by converting the NEWS
file in the spec.

[sebastian at localhost ~]$ rpmlint evolution-couchdb-0.3.2-1.fc12.i686.rpm
evolution-couchdb.i686: W: file-not-utf8
/usr/share/doc/evolution-couchdb-0.3.2/NEWS
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

That's already it, fix them and I'll approve it.

[  OK  ] specfiles match: d8213dfcc77ba17aa289ce09a56181c857bf2fed
[  OK  ] source files match upstream: b1c6a7b1ab7f945e0f35bd59f775f5f9a1a746c8
[  OK  ] package meets naming and versioning guidelines.
[  OK  ] spec is properly named, cleanly written, and uses macros consistently.
[  OK  ] dist tag is present.
[  OK  ] build root is correct.
[ FAIL ] license field matches the actual license.
[  OK  ] license is open source-compatible.
[  OK  ] license text included in package.
[  OK  ] latest version is being packaged.
[  OK  ] BuildRequires are proper.
[  OK  ] compiler flags are appropriate.
[  OK  ] %clean is present. 
[  OK  ] package builds in mock.
[  OK  ] package installs properly.
[  OK  ] debuginfo package looks complete.
[ FAIL ] rpmlint is silent.
[  OK  ] final provides and requires are sane
[  NA  ] %check is present and all tests pass:
[  OK  ] no shared libraries are added to the regular linker search paths.
[  NA  ] owns the directories it creates. 
[  OK  ] doesn't own any directories it shouldn't.
[  OK  ] no duplicates in %files.
[  OK  ] file permissions are appropriate.
[  OK  ] scriptlets match those on ScriptletSnippets page.
[  OK  ] code, not content.
[  OK  ] documentation is small, so no -docs subpackage is necessary.
[  OK  ] %docs are not necessary for the proper functioning of the package.
[  OK  ] no headers.
[  OK  ] no pkgconfig files.
[  OK  ] no libtool .la droppings.
[  NA  ] desktop files valid and installed properly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.