[Bug 519282] Review Request: calibre - e-book converter and library manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519282





--- Comment #19 from Bradley <bbaetz at acm.org>  2009-10-21 20:53:20 EDT ---
This now doesn't build on F11 - you now require poppler-qt-devel > 0.12 but
that's not available. I guess that means that this will be F12 only? (and
shouldn't that be >= rather than >, although it'll still work since 0.12.0 >
0.12)? You may need a similar explicit requires: line if the soname is the same
as the earlier versions

Also, looking at the spec file, you removed the internal python-genshi, but
there's not requires (and buildrequires?) for it. libwmf also isn't required
(only buildreq'd) - is that correct?

And finally, shouldn't:

%{__chmod} -x src/calibre/*/*/*/*py
%{__chmod} -x src/calibre/*/*/*py
%{__chmod} -x src/calibre/*/*py
%{__chmod} -x src/calibre/*py

(and the sed lines above it use *.py rather than *py?

(And again, I'm nt a fedora packager, #include <usual-disclaimers>, etc etc)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.