[Bug 526126] Review Request: python3 - Python 3.x (backwards incompatible version)

bugzilla at redhat.com bugzilla at redhat.com
Thu Oct 22 19:00:02 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526126





--- Comment #26 from Andrew McNabb <amcnabb at mcnabbs.org>  2009-10-22 14:59:56 EDT ---
Dave, I've downloaded your new specfile and taken a look at it.

1) I love the description for __os_install_post.  It explains the problem
clearly and is very helpful.

2) Are there any of our changes that should be submitted upstream?  For
example, the iconv command on line 280 seems like something that should be
fixed upstream.  The same is true for the chmod on line 255, the find/sed on
line 277, and the find command on line 292.

3) The %description probably shouldn't refer to Python 3000, since that was
just a code name and hasn't been used recently.  I would recommend rephrasing
to "Python 3 is a new version of...".

I think you're making great progress.  This spec file is looking better and
better all the time.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list