[Bug 502609] Review Request: sblim-cmpi-syslog - SBLIM syslog instrumentation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502609


Vitezslav Crhonek <vcrhonek at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(vcrhonek at redhat.c |
                   |om)                         |




--- Comment #2 from Vitezslav Crhonek <vcrhonek at redhat.com>  2009-10-23 08:29:07 EDT ---
(In reply to comment #1)
[snip]
> ----------------
> Summary:
> Add shebangs to scripts' 1st line (/bin/sh)

Fixed.

> Move devel files to -devel subpackage

There should be no -devel subpackage. I also moved all libraries to the
provider (cmpi) directory.

> Do not install binary files into /usr/share

I suggest to make exception here - it's part of testing files and these are all
in /usr/share/sblim-testsuite...

> Check CPL license

CPL is fine.

> Why is GPL text in package?

Don't know, it's probably upstream mistake. I checked it and I didn't find
any GPL code, everything is under CPL. I removed COPYING file from the
package, because it's misleading.

> URL tag is not valid.

Fixed.

> Source tarball is not from upstream

Fixed.

> Add rm -rf $RPM_BUILD_ROOT to the start of %install section  

Fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.