[Bug 530205] Review Request: AntTweakBar - GUI library for videogame property editing UIs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=530205





--- Comment #5 from Sean Middleditch <sean at middleditch.us>  2009-10-23 18:52:09 EDT ---
MSVC Express is a free download.  :p  I still don't recommend using it if you
can avoid it either way, though.  Horrifically crappy development environment
compared to vim.  ;)

I emailed upstream about the license discrepancy.  In my totally non-legal
opinion I don't see a problem with the slight difference in wording... but if
upstream is non-responsive, what should I do to get this looked at and approved
by the appropriate parties?

1) I'll replace with %global.  I copied what I had there right out of a KDE
package... which is the only place I could even find that option documented.  I
know it's not your fault at all, but I really have to express how immensely
frustrating the documentation for Fedora packaging is.  There've been a few
cases I've copied code right out of the wiki and then told it didn't meet
policy.  :/

2) There are comments above the patches in the spec file... I thought that's
what the policy meant.  Further expanded that patches have been mamiled.

3) My belief is that no extra Requires should be added at all.  The examples
are just example code, not part of anything you actually have to compile to use
AntTweakBar.  Further, the AntTweakBar.h header and API are explicitly designed
to work independently of any mainloop.  The SDL, GLUT, and GLFW examples are
just examples of how to integrate with those mainloops, but the user can
integrate with Allegro or GTK or Qt or anything else they want to use (so long
as it provides an OpenGL context).  You can easily write and compile code that
links against AntTweakBar and some other toolkit that uses OpenGL internally
without ever using any OpenGL header though, so even a requirement on OpenGL is
not required to use AntTweakBar.  It's fine the way it is, IMO.

Updated spec and SRPM with the patch comments added and the %define->%global
change made.

http://middleditch.us/sean/fedora/AntTweakBar/AntTweakBar.spec
http://middleditch.us/sean/fedora/AntTweakBar/AntTweakBar-1.13-4.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.