[Bug 530568] Review Request: ghmm - A library with data structures and algorithms for Hidden Markov Models

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=530568





--- Comment #3 from D Haley <mycae at yahoo.com>  2009-10-24 11:24:47 EDT ---
SPEC URL: http://dhd.selfip.com/427e/ghmm-4.spec
SRPM URL: http://dhd.selfip.com/427e/ghmm-0.7-4.svn2286.fc10.src.rpm

rpmlint:
$ cat tmp
Wrote: /home/makerpm/rpmbuild/SRPMS/ghmm-0.7-4.svn2286.fc10.src.rpm
Wrote: /home/makerpm/rpmbuild/RPMS/i386/ghmm-0.7-4.svn2286.fc10.i386.rpm
Wrote: /home/makerpm/rpmbuild/RPMS/i386/ghmm-static-0.7-4.svn2286.fc10.i386.rpm
Wrote: /home/makerpm/rpmbuild/RPMS/i386/ghmm-devel-0.7-4.svn2286.fc10.i386.rpm
Wrote:
/home/makerpm/rpmbuild/RPMS/i386/ghmm-debuginfo-0.7-4.svn2286.fc10.i386.rpm

$ rpmlint `cat tmp | awk '{print $2}'`
ghmm.src:94: W: rpm-buildroot-usage %prep -e 's|$(PYTHON) setup.py
install.*$|$(PYTHON) setup.py install -O1 --skip-build --root
${RPM_BUILD_ROOT}|' \
ghmm.i386: W: shared-lib-calls-exit /usr/lib/libghmm.so.1.0.0 exit at GLIBC_2.0
ghmm-static.i386: W: no-documentation
ghmm-devel.i386: W: no-documentation
5 packages and 0 specfiles checked; 0 errors, 4 warnings.
$ sudo rpm -i ../RPMS/i386/ghmm-0.7-4.svn2286.fc10.i386.rpm 
$ rpmlint ghmm
ghmm.i386: W: shared-lib-calls-exit /usr/lib/libghmm.so.1.0.0 exit at GLIBC_2.0
ghmm.i386: W: unused-direct-shlib-dependency /usr/lib/libghmm.so.1.0.0
/usr/lib/libgslcblas.so.0
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

The unused direct-shlib comes from the usage of gsl-config and can be safely
ignored.

koji:
F12: http://koji.fedoraproject.org/koji/taskinfo?taskID=1766163


> - wait for answer about static libs
This is not a problem unless the main package ships static libs, and no
dependant packages are made that use the -static subpackage -- its for end
user-developers only. 

Some discussion on the topic is available here:
http://www.mail-archive.com/fedora-mingw@lists.fedoraproject.org/msg00391.html

>- spurious-executable, non-utf-8 > reduce rpmlint output.
Fixed

>- rename spec file to %{name}.spec
Not required -- name is already %{name}.spec, as seen inside the SRPM. The
-revision bit is only how it is loaded onto my webserver. just mv it when you
wget/curl it.

>- delete CFLAGS="${RPM_OPT_FLAGS}" again :(((  
Done.

>- maybe find a way for building the test suite… :(
It builds -- but a couple of tests fail, triggering a make failure. Upstream
has been notified at
https://sourceforge.net/tracker/?func=detail&aid=2842847&group_id=67094&atid=516867,
however no response from upstream as yet.


Thanks for the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.