[Bug 529084] Review Request: javatar - Java tar archive io package

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=529084





--- Comment #2 from Orion Poplawski <orion at cora.nwra.com>  2009-10-26 19:37:30 EDT ---
Spec URL: http://www.cora.nwra.com/~orion/fedora/javatar.spec
SRPM URL: http://www.cora.nwra.com/~orion/fedora/javatar-2.5-2.fc12.src.rpm

* Mon Oct 26 2009 Orion Poplawski <orion at cora.nwra.com> - 2.5-2
- Remove existing class files
- Package javadocs
- Make sure debuginfo has source files

(In reply to comment #1)
> In the build log, I see this:
> 
> deploy:
>       [jar] Building jar:
> /builddir/build/BUILD/javatar-2.5/tar-2.5/jars/tar.jar
>       [jar] Manifest warning: "Name" attributes should not occur in the main
> section and must be the first element in all other sections: "Name: "Java Tar""
> 
> Is this caused by the sed invocation on the manifest file?  If so, is that
> invocation correct?

The sed simply deletes the existing Class-Path: entry.  I've got no idea about
this.  I'll post the to the fedora java devel list.

>  Also, the source archive contains .class files in
> classes/com/ice/tar.  Would you mind deleting those in %prep, just to be sure
> they don't affect compilation?

Done.

> The javadoc documentation is neither rebuilt nor packaged.  Would you consider
> invoking "ant javadoc", and putting the contents of doc/api into a -javadoc
> subpackage?

It is actually getting built, just not packaged.  Fixed.

> Here is the output of rpmlint:
> 
> javatar-debuginfo.x86_64: E: debuginfo-without-sources
> 
> The warnings are just part of life with GCJ and can be ignored.  The error is a
> problem.  Why are there no sources in the debuginfo package?

I think aot-compile-rpm gets confused with the copy of source files.  Removing
that seems to have fixed it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.