[Bug 521724] Review Request: perl-Makefile-DOM - Simple DOM parser for Makefiles

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=521724





--- Comment #6 from Ryan Lerch <rlerch at redhat.com>  2009-10-26 23:09:17 EDT ---
(In reply to comment #5)
> Ryan,
> 
> Please make sure your BuildRequires include all the ones listed here:
>   https://fedoraproject.org/wiki/Packaging:Perl#Core_modules_as_buildrequires

Done.

> 
> Also please add Provides: perl(Makefile::DOM)  

Also done.

I have uploaded the updated files on my fedorapeople:

http://ryanlerch.fedorapeople.org/perl-Makefile-DOM-0.004-2.fc11.src.rpm
http://ryanlerch.fedorapeople.org/perl-Makefile-DOM.spec

also completed a scratch build in koji:
http://ryanlerch.fedorapeople.org/perl-Makefile-DOM.spec

rpmlint output:
"""
% rpmlint perl-Makefile-DOM.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

% rpmlint perl-Makefile-DOM-0.004-2.fc11.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
"""

anything more i need to do or check on this one?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.