[Bug 477542] Review Request: mpdscribble - A mpd client which submits information about tracks being played to Last.fm

bugzilla at redhat.com bugzilla at redhat.com
Wed Oct 28 09:10:21 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=477542





--- Comment #22 from Peter Lemenkov <lemenkov at gmail.com>  2009-10-28 05:10:19 EDT ---
One small issue still remains (fortunately, the last) - a path for the pid-file
is set to /var/run/$prog/$prog.pid, but you didn't list /var/run/${name} in the
%files section.

Creating extra directory in /var/run, for storing pid-file, is an obvious
solution for permissions issue, when main application runs from different user.
Since mpdscribble runs from root, it doesn't make any sense.

So, I advice you to change variable $pidfile in the init-script to 
/var/run/$prog.pid

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list