[Bug 476600] Review Request: python-ZODB3 - Zope Object Database: Object Database and Persistence

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476600





--- Comment #4 from Conrad Meyer <konrad at tylerc.org>  2009-10-29 01:58:02 EDT ---
(In reply to comment #3)
> >> Mock build fails.

I've built the new version, which builds in rawhide mock for me.

Re: CFLAGS combined with setup.py:
> Right. Diving into it I can see that many packages does it that way - but also
> many noarch packages. And many python arch packages doesn't do it. It seems to
> me like the Python packaging guidelines could use some clarification here?

Yes, I completely agree. The guidelines could use some cleaning up and the spec
templates should be updated to match.

Re: commented out %check section: 
> Doesn't that mean that we need a comment about why it is disabled?

Yes, this is something I should have done, sorry. The age of the review is such
that I don't remember anymore -- I'll figure this out when I build the new
version.

Re: this package installs 4 separate python modules
> That might be true, even though I assume they are separate modules because
> upstream considers them independent?
> 
> I don't feel comfortable with a package reserving such a generic term as
> "persistent" from the global Python module namespace just for its internal use.

Hm, good point. I will package them as separate sub-packages.

New SRPM/SPEC:
http://konradm.fedorapeople.org/fedora/SPECS/python-ZODB3.spec
http://konradm.fedorapeople.org/fedora/SRPMS/python-ZODB3-3.9.3-1.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.