[Bug 528010] Review Request: PyMca - GUI for multi-channel analyser spectra visualization and analysis

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=528010





--- Comment #2 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-10-30 11:34:46 EDT ---
(In reply to comment #1)
> Just a few comments for now:
> 
> - Don't you want to name it PyMCA?

http://pymca.sourceforge.net/faq.html#mozTocId556491

"Due to some problems I encountered with the publisher, I have some preference
for PyMca because it makes clear that it is the name of the program and it does
not intend to be an acronym."


> - BR: python-setuptools-devel is not needed, python-setuptools is enought.

Done for the next release.

> - get rid of /usr/bin/env:
> find %{buildroot}%{python_sitearch}/PyMca -name '*.py' | xargs sed -i
> '/\/usr\/bin\/env/d'
> is much less noisy, than your for loop and 'seems' to act faster, but your
> choice ;). The for loop is just necessary, if you want to keep timestamps…
> Hmm, why don't you?

Keeping time stamps.

> - What do you want to archieve with 'echo yes' in %build and %install?  

The stupid setup macro asks for (GPL) license approval.

http://theory.physics.helsinki.fi/~jzlehtol/rpms/PyMca.spec
http://theory.physics.helsinki.fi/~jzlehtol/rpms/PyMca-4.3.0-2.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.