[Bug 530755] Review Request: dpic - A compiler for the pic language

bugzilla at redhat.com bugzilla at redhat.com
Fri Oct 30 16:43:08 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=530755





--- Comment #2 from Ben Boeckel <mathstuf at gmail.com>  2009-10-30 12:43:06 EDT ---
(In reply to comment #1)
> This fails to build for me:
> 
>  40 pushd doc/examples
>  41 # This is really hairy and parallel builds step on each others' toes
>  42 export PATH=$PATH+:../../
>  43 make DPIC=../../dpic
>  44 popd
> 
> With this export PATH=... the make will find dpic in the currend search path.
> The variable DPIC=../../dpic is not used here, because you commented out the
> examples patch.
I also missed putting the %if around this part.

> But with extending the PATH variable, this patch is not needed, anyway...
The all target is nice :) .

> Atm, this is notready, till you found a way to install the examples ;)
> 
> How about a 
> mkdir -p %{buildroot}%{_datadir}/%{name}/examples/
> cp -a * %{buildroot}%{_datadir}/%{name}/examples/
> 
> in the 'TODO: install examples' - %install section?
I also wanted to ship built examples, but with now the examples are built
things are...hairy. Shipping just the examples should work though.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list