[Bug 531391] Review Request: gwsmhg - hg/mq GUI

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531391


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-10-30 13:59:23 EDT ---
Well,

* debug_package
  - "%define debug_package %{nil}" is not needed for noarch srpm.

! sed line for desktop
  - I suggest to move "sed -i" line to %prep as
    * Modifying text file by sed like this is like applying patches,
      which is usually done at %prep
    * And moving to %prep prevents this line from being called
      with "$ rpmbuild -bc --short-circuit"

* Desktop file
  - Categories "Application" "X-Fedora" are deprecated and should be
    removed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.