[Bug 459872] Review Request: asn1c - Free, open source compiler of ASN.1 specifications into C source code

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459872





--- Comment #12 from Thomas Spura <tomspur at fedoraproject.org>  2009-10-30 18:17:11 EDT ---
(In reply to comment #11)
> (In reply to comment #10)
> > I believe, I read, that, when you are not allowd to redistribute it, you are
> > not allowed to put it in the source tar.gz for uploading and not just deleting
> > in %install or %build.
> 
> rrc.asn1 isn't in upstreams tar.gz and apparently never was. (But it was in
> upstream svn trunk and Peter had included it as an extra source in early specs.
> He never deleted it in %install or %build; he just stopped adding it.) 
> 
How do you call:
%install
rm -rf $RPM_BUILD_ROOT
make install DESTDIR=$RPM_BUILD_ROOT
rm -rf $RPM_BUILD_ROOT%{_docdir}/%{name}/*
rm -f samples/Makefile{,.am,.in}
rm -f samples/clyx2asn1.pl
rm -f samples/crfc2asn1.pl
rm -f samples/sample.makefile.regen

He removes some files, this breaks %check :(

> samples/sample.source.RRC/README is pretty clear.
> 
> > Furthermore, if just deleting
> > 
> > %check
> > make check
> > 
> > fails.
> > 
> > (You should add this into the spec file, too.)  
> 
> Are you saying that %check section is mandatory? That is new to me. AFAICS most
> specs don't have a %check section. Can you give a reference?  

It's not mandatory, but a 'should'. Didn't found it in the main guidelines, but
at least in https://fedoraproject.org/wiki/Packaging:R#Running_.25check

It'll be better to run the testsuite anyway, to see, if there are regressions.
Many specs have a %check section. e.g.
https://bugzilla.redhat.com/show_bug.cgi?id=529466#c8

(In reply to comment #9)
> Conclusion:
> Try to get the samples working - or at least make sure that they not are broken
> by the packaging.
> Consider simplifying %{_datadir}/%{name} in %files  

'Make sure, that they are not broken' is for me the same like running a test
suite.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.