[Bug 532057] Review Request: eclipse-jgit - Eclipse JGit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532057


Peter Lemenkov <lemenkov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lemenkov at gmail.com




--- Comment #1 from Peter Lemenkov <lemenkov at gmail.com>  2009-10-31 14:49:53 EDT ---
Issues:

* First, and most important - I don't know too much about eclipse plugins, but
I'm sure, that using %{_libdir} in spec-file renders package to be
arch-dependent. So, I believe, that either noarch should be removed, or
"%define eclipse_base   %{_libdir}/eclipse" should be fixed to not contain
%{_libdir}.

* Naming scheme is somewhat wrong. Instead of "Release:       
0.git20091029.1%{?dist}" it should be

Release:        0.1.git20091029%{?dist}

Other things looks sane.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.