[Bug 579060] Review Request: perl-String-Formatter - Build sprintf-like functions of your own

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=579060

--- Comment #1 from Chris Weyl <cweyl at alumni.drew.edu> 2010-04-02 11:40:31 EDT ---
Looks good!

Your sed syntax is interesting: "sed -i -e '1s~#!perl~#!%{__perl}~' bench.pl".
Am I correct in thinking the leading "1" constrains sed to tinkering with the
first line only?  Or only one match?

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2091038

Spec looks sane, clean and consistent; license is correct (GPLv2);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
4ff6a1d173c7f51ef794a8c9d63e6e17a60f62d0 String-Formatter-0.100720.tar.gz
4ff6a1d173c7f51ef794a8c9d63e6e17a60f62d0 String-Formatter-0.100720.tar.gz.srpm

Final provides / requires are sane:

0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-String-Formatter-0.100720-1.fc14.noarch.rpm <=====
====> rpmlint
perl-String-Formatter.noarch: W: spelling-error Summary(en_US) sprintf ->
sprint, sprints, sprint f
perl-String-Formatter.noarch: W: spelling-error %description -l en_US sprintf
-> sprint, sprints, sprint f
perl-String-Formatter.noarch: W: spelling-error %description -l en_US expanders
-> ex panders, ex-panders, expands
perl-String-Formatter.noarch: W: spelling-error %description -l en_US
formatters -> for matters, for-matters, formatted
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
====> provides for perl-String-Formatter-0.100720-1.fc14.noarch.rpm
perl(String::Formatter) = 0.100720
perl-String-Formatter = 0.100720-1.fc14
perl(String::Formatter::Cookbook) = 0.100720
====> requires for perl-String-Formatter-0.100720-1.fc14.noarch.rpm
perl >= 0:5.006
perl(:MODULE_COMPAT_5.10.1)  
perl(Params::Util)  
perl(strict)  
perl(Sub::Exporter)  
perl(warnings)  

=====> perl-String-Formatter-0.100720-1.fc14.src.rpm <=====
====> rpmlint
perl-String-Formatter.src: W: spelling-error Summary(en_US) sprintf -> sprint,
sprints, sprint f
perl-String-Formatter.src: W: spelling-error %description -l en_US sprintf ->
sprint, sprints, sprint f
perl-String-Formatter.src: W: spelling-error %description -l en_US expanders ->
ex panders, ex-panders, expands
perl-String-Formatter.src: W: spelling-error %description -l en_US formatters
-> for matters, for-matters, formatted
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
====> provides for perl-String-Formatter-0.100720-1.fc14.src.rpm
====> requires for perl-String-Formatter-0.100720-1.fc14.src.rpm
perl >= 0:5.006
perl(ExtUtils::MakeMaker)  
perl(Params::Util)  
perl(Pod::Coverage::TrustPod)  
perl(Sub::Exporter)  
perl(Test::More)  
perl(Test::Pod)  
perl(Test::Pod::Coverage)  

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.